fix(comfy): prevent double loading of custom nodes #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `services/comfy/extra_model_paths.yaml` configuration redundantly specified the `custom_nodes` path, which is already mounted and linked by `entrypoint.sh`. This caused ComfyUI to scan the same directory twice via different paths, leading to double-loading of nodes. This issue caused process-local memory caching failures in extensions like `comfyui-tooling-nodes`, where the Web API and Workflow Executor would see different instances of the cache. Removing the explicit `custom_nodes` entry from the YAML configuration resolves this by ensuring nodes are loaded only once from the canonical path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
services/comfy/extra_model_paths.yamlconfiguration redundantly specified thecustom_nodespath, which is already mounted and linked byentrypoint.sh. This caused ComfyUI to scan the same directory twice via different paths, leading to double-loading of nodes.This issue caused process-local memory caching failures in extensions like
comfyui-tooling-nodes, where the Web API and Workflow Executor would see different instances of the cache.Removing the explicit
custom_nodesentry from the YAML configuration resolves this by ensuring nodes are loaded only once from the canonical path.Closes issue #20