-
-
Notifications
You must be signed in to change notification settings - Fork 351
feat: register: Implement --drop flag mirroring functionality #2538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: register: Implement --drop flag mirroring functionality #2538
Conversation
|
Nice! Would you mind mentioning it briefly in the body of Register.md also. (The flags list at the top will be regenerated before release, so updating that is optional.) |
2860b63 to
5aa16af
Compare
|
Something like that? |
|
Great. There's still a build warning; hopefully |
|
Unfortunately none of the |
5aa16af to
ac26388
Compare
This implements the same --drop functionality as balance command for register subcommand, allowing users to trim leading account name components from register output.
ac26388 to
1f911cf
Compare
Could you help me understand this kind of situation better ? What ghc version(s), installed by what method, do you have ? |
|
PR looks good - thank you! |
GHC 9.6.6 installed by system packages on Arch. Yes it is ancient, yes there is work being done to update it, but our whole Haskell stack being dynamically linked is a huge pain point. GHCID is just not packaged at all, probably because it wasn't compatible with whatever ghc we had a while back and had to get dropped to unblock a ghc update. I see it does actually build at the moment. I'll check on it again when the GHC stack gets fully up to date and see if it can get added. |
|
Ah Arch. (It's always Arch. :) But, GHC 9.6 is still supported by hledger, so it shouldn't be a big deal to use it. It might be enough to change this line in Justfile (make it use stack96.yaml): ghcid is not something you need, probably. I use it only when HLS in VS Code isn't working. We do want it to be easy for everyone to be able to run |
|
Related: recent discussion of Justfile/test portability and dev docs at #2528. |
This implements the same --drop functionality as balance command for register subcommand, allowing users to trim leading account name components from register output.