Skip to content

Change transfers status remotely for librarian self#139

Open
iparask wants to merge 6 commits intomainfrom
gp/feat/disable_transfers
Open

Change transfers status remotely for librarian self#139
iparask wants to merge 6 commits intomainfrom
gp/feat/disable_transfers

Conversation

@iparask
Copy link
Copy Markdown
Member

@iparask iparask commented May 2, 2025

No description provided.

@iparask iparask requested a review from Copilot May 2, 2025 14:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces two new endpoints that allow a librarian to view and update their transfers status remotely, along with the associated Pydantic models for request and response validation.

  • Added an endpoint to check the transfer status.
  • Added an endpoint to update the transfer status.
  • Introduced new models in the transfers module to support these endpoints.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
librarian_server/api/transfers.py Adds endpoints for checking and updating transfer status.
hera_librarian/models/transfers.py Defines Pydantic models for transfer status requests and responses.
Comments suppressed due to low confidence (1)

librarian_server/api/transfers.py:67

  • The function name 'update' is used for both the status endpoint and the transfer update endpoint; consider renaming one to better reflect its purpose.
def update(

@iparask iparask requested a review from JBorrow May 16, 2025 17:51
@iparask iparask marked this pull request as ready for review May 23, 2025 15:39
@iparask
Copy link
Copy Markdown
Member Author

iparask commented May 23, 2025

Any suggestions how to test this?

@JBorrow
Copy link
Copy Markdown
Member

JBorrow commented Jun 17, 2025

You can test using the two servers like this: https://github.com/simonsobs/librarian/blob/main/tests/integration_test/test_sneaker.py

@iparask iparask changed the title WIP: change transfers status remotely for librarian self Change transfers status remotely for librarian self Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants