Change transfers status remotely for librarian self#139
Open
Change transfers status remotely for librarian self#139
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces two new endpoints that allow a librarian to view and update their transfers status remotely, along with the associated Pydantic models for request and response validation.
- Added an endpoint to check the transfer status.
- Added an endpoint to update the transfer status.
- Introduced new models in the transfers module to support these endpoints.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| librarian_server/api/transfers.py | Adds endpoints for checking and updating transfer status. |
| hera_librarian/models/transfers.py | Defines Pydantic models for transfer status requests and responses. |
Comments suppressed due to low confidence (1)
librarian_server/api/transfers.py:67
- The function name 'update' is used for both the status endpoint and the transfer update endpoint; consider renaming one to better reflect its purpose.
def update(
Member
Author
|
Any suggestions how to test this? |
Member
|
You can test using the two servers like this: https://github.com/simonsobs/librarian/blob/main/tests/integration_test/test_sneaker.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.