Improved handling of dark templates in the presence of flags #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskisner
force-pushed
the
dark_template_flags
branch
from
80ed1c0 to
4ac1726
Compare
tskisner
force-pushed
the
dark_template_flags
branch
2 times, most recently
from
dd01d2d to
7ca4ab3
Compare
- In trend cuts, disregard the slope of chunks without a sufficient number of good samples. - In dark templates, handle cases where many samples are flagged, and also cases where there are no remaining dark detectors after cuts. - Other small cleanups
tskisner
force-pushed
the
dark_template_flags
branch
from
7ca4ab3 to
4385d14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work more carefully checks flagged samples within each dark detector TOD and fills gaps before building dark templates.