Skip to content

fix: fix pointing model application for SATs in ffp #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skhrg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fix pointing model application for SATs in ffp #1470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions sotodlib/site_pipeline/finalize_focal_plane.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,11 +463,14 @@ def _apply_pointing_model(config, aman):
config["pointing_model"]["function"][1],
)
if "az" not in aman.pointing:
raise ValueError("Need to have az in pointing fits to apply pointing model")
logger.warning("\t\tNeed to have az in pointing fits to apply pointing model! Filling from obsdb")
aman.pointing.wrap("az", np.deg2rad(aman.obs_info.az_center)*np.ones(aman.dets.count), [(0, aman.dets)])
if "el" not in aman.pointing:
raise ValueError("Need to have el in pointing fits to apply pointing model")
logger.warning("\t\tNeed to have el in pointing fits to apply pointing model! Filling from obsdb")
aman.pointing.wrap("el", np.deg2rad(aman.obs_info.el_center)*np.ones(aman.dets.count), [(0, aman.dets)])
if "roll" not in aman.pointing:
raise ValueError("Need to have roll in pointing fits to apply pointing model")
logger.warning("\t\tNeed to have roll in pointing fits to apply pointing model! Filling from obsdb")
aman.pointing.wrap("roll", np.deg2rad(aman.obs_info.roll_center)*np.ones(aman.dets.count), [(0, aman.dets)])

params = config["pointing_model"].get("params", {})
if "pointing_model" in aman:
Expand All @@ -481,6 +484,7 @@ def _apply_pointing_model(config, aman):
ancil.wrap("az_enc", np.rad2deg(aman.pointing.az))
ancil.wrap("el_enc", np.rad2deg(aman.pointing.el))
ancil.wrap("roll_enc", np.rad2deg(aman.pointing.roll))
ancil.wrap("boresight_enc", -1*np.rad2deg(aman.pointing.roll)) # for SATs
bs = func(aman, params, ancil, False)
q_fp = quat.rotation_xieta(aman.pointing.xi, aman.pointing.eta)
have_gamma = False
Expand All @@ -499,7 +503,7 @@ def _apply_pointing_model(config, aman):
~quat.euler(2, bs.roll)
* ~quat.rotation_lonlat(-bs.az, bs.el)
* quat.rotation_lonlat(-1 * aman.pointing.az, aman.pointing.el)
* quat.euler(2, aman.pointing.roll)
* quat.euler(2, (not config["pointing_model"].get("force_zero_roll", False)) * aman.pointing.roll)
* q_fp
)

Expand Down