fix: make attachment content loading properly asyncio-friendly #1143 #1195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal to fix #1143
Since all invocations in
llm.Attachment
are doing IO usinghttpx
non-async primitives, we canasyncify
build_messages
by executing it in a different thread usingasyncio.to_thread
.The same can be verified using the following code (event loop block detected with pyleak).
Before
with
messages = self.build_messages(prompt, conversation)
After
with
messages = await asyncify(self.build_messages, prompt, conversation)
I've also added a unit test that detects event loop blocking using
pytest.mark.pyleak
with mocked ahttpx.head
response.