Skip to content

Add log flags and respect log setting for chat() #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add log flags and respect log setting for chat() #1247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion llm/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,6 +977,8 @@ async def inner():
help="Path to log database",
)
@click.option("--no-stream", is_flag=True, help="Do not stream output")
@click.option("-n", "--no-log", is_flag=True, help="Don't log to database")
@click.option("--log", is_flag=True, help="Log prompt and response to the database")
@click.option("--key", help="API key to use")
@click.option(
"tools",
Expand Down Expand Up @@ -1025,6 +1027,8 @@ def chat(
param,
options,
no_stream,
no_log,
log,
key,
database,
tools,
Expand All @@ -1036,6 +1040,9 @@ def chat(
"""
Hold an ongoing chat with a model.
"""
if log and no_log:
raise click.ClickException("--log and --no-log are mutually exclusive")

# Left and right arrow keys to move cursor:
if sys.platform != "win32":
readline.parse_and_bind("\\e[D: backward-char")
Expand Down Expand Up @@ -1234,7 +1241,9 @@ def chat(
for chunk in response:
print(chunk, end="")
sys.stdout.flush()
response.log_to_db(db)

if (logs_on() or log) and not no_log:
response.log_to_db(db)
print("")


Expand Down