perf: use deque for async response chunk iteration#1362
Open
giulio-leone wants to merge 1 commit intosimonw:mainfrom
Open
perf: use deque for async response chunk iteration#1362giulio-leone wants to merge 1 commit intosimonw:mainfrom
giulio-leone wants to merge 1 commit intosimonw:mainfrom
Conversation
AsyncResponse.__anext__() replays cached chunks via list.pop(0) when the response is already done, which is O(n) per removal. Switch to collections.deque with popleft() for O(1).
553ccca to
3f80a2a
Compare
Author
|
Friendly ping — CI is green and this is ready for review. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AsyncResponse.__anext__()replays cached chunks when the response is already done vialist.pop(0), which is O(n) per removal. For long responses with many chunks, replaying becomes O(n²).Solution
Switch
_iter_chunksfromlisttocollections.deque, replacing.pop(0)with.popleft()for O(1) front removal.Changes
llm/models.py:dequefromcollections_iter_chunks = deque(self._chunks)instead oflist(...).pop(0)→.popleft()Testing
ast.parse()