Merged
Conversation
Use a default log in Inversion if `log=True`, so the user doesn't need to build it and pass it. If `log=False`, then `Inversion.log` will be `None`. Users can still pass their custom `InversionLog`. Move the first call of `log.update()` to the `__next__` method, only executed in the first iteration. This makes Inversion instantiation faster (no calls to objective functions), and allows users to edit the log columns before the inversion has started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a default log in Inversion if
log=True, so the user doesn't need to build it and pass it. Iflog=False, thenInversion.logwill beNone. Users can still pass their customInversionLog. Move the first call oflog.update()to the__next__method, only executed in the first iteration. This makes Inversion instantiation faster (no calls to objective functions), and allows users to edit the log columns before the inversion has started. Rerun notebooks.