Improve caching decorator and move it to simulations#73
Merged
santisoler merged 5 commits intomainfrom Feb 10, 2026
Merged
Conversation
Improve the decorator so it can be used in multiple methods within
a same object. Change how the cache objects are stored: each
`_cache_{hash(func)}` attribute will be a tuple with two elements: the
hash of the model and the cached return of the `func`.
This way, two different methods can have their own caches, even for
different models.
Using the decorator on `DataMisfit` methods would force us to also validate other relevant attributes, like the data, their uncertainties and the weights.
Use the decorator on the `__call__` and the `jacobian` methods of the `WrappedSimulation`.
The caching of the J matrix should happen in `getJ`. And there's no gain in caching the LinearOperator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the decorator so it can be used in multiple methods within a same object. Change how the cache objects are stored: each
_cache_{hash(func)}attribute will be a tuple with two elements: the hash of the model and the cached return of thefunc. This way, two different methods can have their own caches, even for different models. Remove thecache_on_modeldecorator fromDataMisfit. Using the decorator onDataMisfitmethods would force us to also validate other relevant attributes, like the data, their uncertainties and the weights. Use the decorator on the__call__method of theWrappedSimulation.