Open
Conversation
Updated the README to include a pre-configured connection string for SQL Server LocalDB. This helps new contributors who have Visual Studio installed but do not have a standalone SQL Server instance running, lowering the barrier to entry for the project.
Contributor
Author
|
Hi @hishamco , Please review and approve the PR |
|
hishamco
requested changes
Mar 9, 2026
|
|
||
| [Required(ErrorMessage = "Phone number is required")] | ||
| [Phone(ErrorMessage = "Please enter a valid phone number")] | ||
| [StringLength(20, MinimumLength = 10, ErrorMessage = "Phone number must be between 10 and 20 characters")] |
| <label class="col-sm-4 col-form-label">@Localizer["Phone"]</label> | ||
| <div class="col-sm-8"> | ||
| <input asp-for="NewAddressForm.Phone" type="text" class="form-control"> | ||
| <input asp-for="NewAddressForm.Phone" type="tel"inputmode="numeric" class="form-control" |
Member
There was a problem hiding this comment.
The phone can support formats like this +967-7-XXXXXXX.
Comment on lines
+86
to
+87
| <input asp-for="NewAddressForm.Phone" type="tel"inputmode="numeric" class="form-control" | ||
| oninput="this.value = this.value.split('').filter(function(c){return c >= '0' && c <= '9';}).join('');"> |
Member
There was a problem hiding this comment.
Suggested change
| <input asp-for="NewAddressForm.Phone" type="tel"inputmode="numeric" class="form-control" | |
| oninput="this.value = this.value.split('').filter(function(c){return c >= '0' && c <= '9';}).join('');"> | |
| <input asp-for="NewAddressForm.Phone" type="tel" class="form-control" oninput="this.value = this.value.replace(/[^0-9+]/g, '')"> |
Comment on lines
+178
to
+179
| <input asp-for="NewBillingAddressForm.Phone" type="tel" inputmode="numeric" class="form-control" | ||
| oninput="this.value = this.value.split('').filter(function(c){return c >= '0' && c <= '9';}).join('');"> |
Member
There was a problem hiding this comment.
Suggested change
| <input asp-for="NewBillingAddressForm.Phone" type="tel" inputmode="numeric" class="form-control" | |
| oninput="this.value = this.value.split('').filter(function(c){return c >= '0' && c <= '9';}).join('');"> | |
| <input asp-for="NewBillingAddressForm.Phone" type="tel" class="form-control" oninput="this.value = this.value.replace(/[^0-9+]/g, '')"> |
|
|
||
| [Required(ErrorMessage = "Phone number is required")] | ||
| [Phone(ErrorMessage = "Please enter a valid phone number")] | ||
| [StringLength(20, MinimumLength = 10, ErrorMessage = "Phone number must be between 10 and 20 characters")] |
Member
There was a problem hiding this comment.
Suggested change
| [StringLength(20, MinimumLength = 10, ErrorMessage = "Phone number must be between 10 and 20 characters")] | |
| [StringLength(15, MinimumLength = 10, ErrorMessage = "Phone number must be between 10 and 15 characters")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code fix for Phone field accepting non numeric fields.