Fix version check load order issue #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the version causes an error when `simplecov-html` is loaded before `simplecov`: ``` require "bundler/inline" gemfile(true) do source "https://rubygems.org" gem "simplecov-html" gem "simplecov" end ``` ``` /home/user/code/simplecov-html/lib/simplecov-html.rb:10:in '<top (required)>': uninitialized constant SimpleCov::VERSION (NameError) major, minor, patch = SimpleCov::VERSION.scan(/\d+/).first(3).map(&:to_i) ^^^^^^^^^ from <internal:/home/user/.rbenv/versions/3.4-dev/lib/ruby/3.4.0+0/rubygems/core_ext/kernel_require.rb>:37:in 'Kernel#require' ``` I don't think this check is even needed anymore but I'd just leave it in
Earlopain
force-pushed
the
version-constraint
branch
from
daee97f to
9c9f1ea
Compare
|
Hi @amatsuda, sorry to be a bother. Could you consider merging this? I ran into this again and would appreciate you taking a look. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the version causes an error when
simplecov-htmlis loaded beforesimplecov:I don't think this check is even needed anymore but I'd just leave it in