Show smoking status dialog when cvd risk is LOW-HIGH or MEDIUM-HIGH
#5229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddh1004
force-pushed
the
siddharth-agarwal/sc-14643
branch
2 times, most recently
from
cf16e66 to
a0209a5
Compare
simple-services
requested review from
a team and
msasikanth
and removed request for
a team
msasikanth
suggested changes
Feb 3, 2025
| (event.statinInfo.cvdRisk?.level == CVDRiskLevel.LOW_HIGH || | ||
| event.statinInfo.cvdRisk?.level == CVDRiskLevel.MEDIUM_HIGH) && | ||
| event.statinInfo.isSmoker == MedicalHistoryAnswer.Unanswered && | ||
| !model.hasShownSmokingStatusDialog |
Contributor
There was a problem hiding this comment.
While this works, and we can leave this for now. The underlying problem still exists. The statin info is being reloaded every time patient info changes. So, the LoadStatinPrescriptionCheckInfo effect gets triggered every time.
Contributor
Author
There was a problem hiding this comment.
Thanks for flagging this out. I will create a story and move to backlog.
Contributor
|
Please update the CHANGELOG as well |
siddh1004
force-pushed
the
siddharth-agarwal/sc-14643
branch
from
a0209a5 to
9d50169
Compare
siddh1004
force-pushed
the
siddharth-agarwal/sc-14643
branch
from
f144e4a to
83547ac
Compare
siddh1004
force-pushed
the
siddharth-agarwal/sc-14643
branch
from
83547ac to
bad987c
Compare
msasikanth
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.shortcut.com/simpledotorg/story/14643/show-smoking-dialog-if-risk-is-low-high-or-medium-high?team_id=1&iteration_ids=14465&iteration_ids=14489