Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@
- Bump AndroidX Test Runner to v1.7.0
- Bump AndroidX Test Rules to v1.7.0
- Bump AndroidX JUnit to v1.3.0
- Bump Jackson Core to v2.20.0
- Bump Play Services Auth to v21.4.0
- Bump Material Components to v1.12.0
- Bump Kotlin to v2.2.20
- Bump AndroidX Work to v2.10.4
- Bump AndroidX ViewModel to v2.9.4

### Changes

- Hide next button when registration is going

## 2025.09.09

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,14 @@ class RegistrationPhoneScreen :
progressView.visibility = View.GONE
}

override fun showNextButton() {
nextButtonFrame.visibility = View.VISIBLE
}

override fun hideNextButton() {
nextButtonFrame.visibility = View.GONE
}

override fun openLoginPinEntryScreen() {
router.push(LoginPinScreenKey())
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@ interface RegistrationPhoneUi {
fun hideAnyError()
fun showProgressIndicator()
fun hideProgressIndicator()
fun showNextButton()
fun hideNextButton()
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ class RegistrationPhoneUiRenderer(
if (mode == RegistrationUiMode.RegistrationOngoing) {
registrationResultValueCallback.clear()
ui.showProgressIndicator()
ui.hideNextButton()
} else {
ui.hideProgressIndicator()
ui.showNextButton()
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ class RegistrationPhoneScreenLogicTest {

// then
verify(ui).showProgressIndicator()
verify(ui).hideNextButton()
verify(findUserWithPhoneNumber).find(inputNumber)
}

Expand All @@ -176,6 +177,8 @@ class RegistrationPhoneScreenLogicTest {
// then
verify(ui).showProgressIndicator()
verify(ui).hideProgressIndicator()
verify(ui).hideNextButton()
verify(ui).showNextButton()
verify(ui).showUnexpectedErrorMessage()

clearInvocations(ui)
Expand All @@ -186,6 +189,8 @@ class RegistrationPhoneScreenLogicTest {
// then
verify(ui).showProgressIndicator()
verify(ui).hideProgressIndicator()
verify(ui).hideNextButton()
verify(ui).showNextButton()
verify(ui).showNetworkErrorMessage()
}

Expand Down Expand Up @@ -291,6 +296,7 @@ class RegistrationPhoneScreenLogicTest {

// then
verify(ui).showProgressIndicator()
verify(ui).hideNextButton()
verify(facilitySync).pullWithResult()
}

Expand Down Expand Up @@ -324,6 +330,7 @@ class RegistrationPhoneScreenLogicTest {

// then
verify(ui).hideProgressIndicator()
verify(ui).showNextButton()
verify(ui).showNetworkErrorMessage()
verify(findUserWithPhoneNumber, never()).find(phoneNumber)
}
Expand All @@ -342,6 +349,7 @@ class RegistrationPhoneScreenLogicTest {

// then
verify(ui).hideProgressIndicator()
verify(ui).showNextButton()
verify(ui).showUnexpectedErrorMessage()
verify(findUserWithPhoneNumber, never()).find(phoneNumber)
}
Expand Down
12 changes: 6 additions & 6 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@ androidx-cameraView = "1.4.2"
androidx-camera = "1.4.2"
androidx-paging = "3.3.6"
androidx-room = "2.7.2"
androidx-work = "2.10.3"
androidx-work = "2.10.4"
androidx-security-crypto = "1.1.0-alpha07"
androidx-viewmodel = "2.9.3"
androidx-viewmodel = "2.9.4"
androidx-lifecycle = "2.9.4"
androidx-activity = "1.10.1"

chucker = "4.2.0"
dagger = "2.57.1"

kotlin = "2.2.10"
kotlin = "2.2.20"

ksp = "2.2.10-2.0.2"

Expand Down Expand Up @@ -116,7 +116,7 @@ itemanimators = "com.mikepenz:itemanimators:1.1.0"

itext7 = "com.itextpdf:itext7-core:7.2.5"

jackson-core = "com.fasterxml.jackson.core:jackson-core:2.19.2"
jackson-core = "com.fasterxml.jackson.core:jackson-core:2.20.0"

jbcrypt = "org.mindrot:jbcrypt:0.4"

Expand All @@ -140,7 +140,7 @@ logback-classic = "ch.qos.logback:logback-classic:1.2.11"

lottie = "com.airbnb.android:lottie-compose:6.6.7"

material = "com.google.android.material:material:1.12.0"
material = "com.google.android.material:material:1.13.0"

mockito-kotlin = "org.mockito.kotlin:mockito-kotlin:5.4.0"

Expand All @@ -160,7 +160,7 @@ okhttp-interceptor-logging = { module = "com.squareup.okhttp3:logging-intercepto
openCsv = "com.opencsv:opencsv:5.12.0"

play-app-update = "com.google.android.play:app-update-ktx:2.1.0"
play-services-auth = "com.google.android.gms:play-services-auth:21.3.0"
play-services-auth = "com.google.android.gms:play-services-auth:21.4.0"
play-services-location = "com.google.android.gms:play-services-location:21.3.0"
play-services-mlkit-barcode = "com.google.android.gms:play-services-mlkit-barcode-scanning:18.3.1"

Expand Down
Loading