Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9c4b0cf
Update dependency androidx.lifecycle:lifecycle-livedata-ktx to v2.9.4…
renovate[bot] Sep 23, 2025
82d27d0
Update dependency androidx.test:runner to v1.7.0 (#5581)
renovate[bot] Sep 23, 2025
8059de3
Update dependency androidx.test:rules to v1.7.0 (#5579)
renovate[bot] Sep 23, 2025
4ea5641
Update dependency androidx.test.ext:junit to v1.3.0 (#5582)
renovate[bot] Sep 23, 2025
6f86f2b
Hide next button when registration is going (#5610)
siddh1004 Sep 24, 2025
e9c73a4
Update dependency com.fasterxml.jackson.core:jackson-core to v2.20.0 …
renovate[bot] Sep 24, 2025
d909284
Update dependency com.google.android.gms:play-services-auth to v21.4.…
renovate[bot] Sep 24, 2025
038fce4
Update dependency com.google.android.material:material to v1.13.0 (#5…
renovate[bot] Sep 24, 2025
a02d8af
Update kotlin monorepo to v2.2.20 (#5598)
renovate[bot] Sep 24, 2025
6410883
Update androidx.work to v2.10.4 (#5603)
renovate[bot] Sep 24, 2025
41963ec
Update androidx.viewmodel to v2.9.4 (#5609)
renovate[bot] Sep 24, 2025
e487e75
Update dependency com.airbnb.android:lottie-compose to v6.6.9 (#5611)
renovate[bot] Sep 25, 2025
20f910f
Update dependency com.google.code.gson:gson to v2.13.2 (#5612)
renovate[bot] Sep 25, 2025
24206d1
Update dependency com.google.devtools.ksp to v2.2.20-2.0.2 (#5613)
renovate[bot] Sep 26, 2025
93a815b
Update library versions (#5627)
siddh1004 Sep 29, 2025
9cfb30b
Update dependencies (#5632)
siddh1004 Sep 29, 2025
689133e
Update actions/checkout action to v5 (#5634)
renovate[bot] Sep 29, 2025
6635acb
Update actions/setup-java action to v5 (#5635)
renovate[bot] Sep 30, 2025
7c80db1
Update Gradle to v9 (#5637)
renovate[bot] Sep 30, 2025
06b71ba
Update dependency org.mockito.kotlin:mockito-kotlin to v6 (#5636)
renovate[bot] Sep 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/benchmark_suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
sudo udevadm trigger --name-match=kvm

- name: Checkout Android source
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Setup JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'zulu'
java-version: 17
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ jobs:

- name: Checkout
if: github.event.inputs.tramline-input == null || github.event.inputs.tramline-input == ''
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Setup JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 17
distribution: zulu
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_sandbox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ jobs:

- name: Checkout
if: github.event.inputs.tramline-input == null || github.event.inputs.tramline-input == ''
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Setup JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 17
distribution: zulu
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ jobs:

- name: Checkout
if: github.event.inputs.tramline-input == null || github.event.inputs.tramline-input == ''
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Setup JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 17
distribution: zulu
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/ci_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
runs-on: [ ubuntu-latest ]
if: github.event_name == 'pull_request'
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Verify PR description
run: .github/scripts/story_link_check.sh '${{ github.event.pull_request.body }}'

Expand All @@ -27,13 +27,13 @@ jobs:
if: github.event_name == 'pull_request'
steps:
- name: Checkout master
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
ref: master
path: master

- name: Checkout current
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
path: current

Expand All @@ -43,10 +43,10 @@ jobs:
lint:
runs-on: [ ubuntu-latest ]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Setup JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'zulu'
java-version: 17
Expand All @@ -58,10 +58,10 @@ jobs:
unit_tests:
runs-on: [ ubuntu-latest ]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Setup JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'zulu'
java-version: 17
Expand All @@ -87,7 +87,7 @@ jobs:


- name: Checkout Android source
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Start Simple Docker server
run: |
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
script: echo "Generated AVD snapshot for caching."

- name: set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'zulu'
java-version: 17
Expand Down Expand Up @@ -182,13 +182,13 @@ jobs:
runs-on: [ ubuntu-latest ]
steps:
- name: Checkout master
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
ref: master
path: master

- name: Checkout current
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
path: current

Expand All @@ -199,7 +199,7 @@ jobs:
runs-on: [ ubuntu-latest ]
if: github.event_name == 'pull_request'
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
ref: ${{github.event.pull_request.head.ref}}
fetch-depth: 0
Expand Down
34 changes: 31 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,43 @@
## Next Release

### Internal
- Bump Sentry to v8.21.1
- Bump Sentry to v8.22.0
- Bump AndroidX Lifecycle to v2.9.4
- Bump AndroidX Test Runner to v1.7.0
- Bump AndroidX Test Rules to v1.7.0
- Bump AndroidX JUnit to v1.3.0
- Bump Jackson Core to v2.20.0
- Bump Play Services Auth to v21.4.0
- Bump Material Components to v1.12.0
- Bump Kotlin to v2.2.20
- Bump AndroidX Work to v2.10.5
- Bump AndroidX ViewModel to v2.9.4
- Bump Lottie Compose to v6.6.9
- Bump Gson to v2.13.2
- Bump KSP to v2.2.20-2.0.2
- Bump firebase remote config to v23.0.1
- Bump Google Truth to v1.4.5
- Bump AndroidX Benchmark to v1.4.1
- Bump AndroidX Camera to v1.5.0
- Bump AndroidX Camera View to v1.5.0
- Bump dagger to v2.57.2
- Bump UUID generator to v5.1.1
- Bump Compose BOM to v2025.09.01
- Bump Sentry Android to v5.12.0
- Update GH Actions `checkout` to v5
- Update GH Actions `setup-jdk` to to v5
- Bump Gradle to v9.1.0
- Bump Mockito Kotlin to v6.0.0

### Changes

- Hide next button when registration is going

## 2025.09.09

### Internal
- Bump AGP to v8.13.0
- Bump Lint to v31.13.0
- Bump Kotlin to v2.2.0
- Bump KSP to v2.2.0-2.0.2
- Bump dagger to v2.57.1
- Bump okhttp to v5.1.0
- Bump retrofit to v3.0.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,14 @@ class RegistrationPhoneScreen :
progressView.visibility = View.GONE
}

override fun showNextButton() {
nextButtonFrame.visibility = View.VISIBLE
}

override fun hideNextButton() {
nextButtonFrame.visibility = View.GONE
}

override fun openLoginPinEntryScreen() {
router.push(LoginPinScreenKey())
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@ interface RegistrationPhoneUi {
fun hideAnyError()
fun showProgressIndicator()
fun hideProgressIndicator()
fun showNextButton()
fun hideNextButton()
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ class RegistrationPhoneUiRenderer(
if (mode == RegistrationUiMode.RegistrationOngoing) {
registrationResultValueCallback.clear()
ui.showProgressIndicator()
ui.hideNextButton()
} else {
ui.hideProgressIndicator()
ui.showNextButton()
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ class RegistrationPhoneScreenLogicTest {

// then
verify(ui).showProgressIndicator()
verify(ui).hideNextButton()
verify(findUserWithPhoneNumber).find(inputNumber)
}

Expand All @@ -176,6 +177,8 @@ class RegistrationPhoneScreenLogicTest {
// then
verify(ui).showProgressIndicator()
verify(ui).hideProgressIndicator()
verify(ui).hideNextButton()
verify(ui).showNextButton()
verify(ui).showUnexpectedErrorMessage()

clearInvocations(ui)
Expand All @@ -186,6 +189,8 @@ class RegistrationPhoneScreenLogicTest {
// then
verify(ui).showProgressIndicator()
verify(ui).hideProgressIndicator()
verify(ui).hideNextButton()
verify(ui).showNextButton()
verify(ui).showNetworkErrorMessage()
}

Expand Down Expand Up @@ -291,6 +296,7 @@ class RegistrationPhoneScreenLogicTest {

// then
verify(ui).showProgressIndicator()
verify(ui).hideNextButton()
verify(facilitySync).pullWithResult()
}

Expand Down Expand Up @@ -324,6 +330,7 @@ class RegistrationPhoneScreenLogicTest {

// then
verify(ui).hideProgressIndicator()
verify(ui).showNextButton()
verify(ui).showNetworkErrorMessage()
verify(findUserWithPhoneNumber, never()).find(phoneNumber)
}
Expand All @@ -342,6 +349,7 @@ class RegistrationPhoneScreenLogicTest {

// then
verify(ui).hideProgressIndicator()
verify(ui).showNextButton()
verify(ui).showUnexpectedErrorMessage()
verify(findUserWithPhoneNumber, never()).find(phoneNumber)
}
Expand Down
Loading
Loading