Skip to content

Commit 748ff92

Browse files
committed
fix #121 - add calls to Sensor::init()
1 parent c99dd26 commit 748ff92

File tree

6 files changed

+10
-0
lines changed

6 files changed

+10
-0
lines changed

src/sensors/Encoder.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ void Encoder::init(){
205205
// change it if the mode is quadrature
206206
if(quadrature == Quadrature::ON) cpr = 4*cpr;
207207

208+
// we don't call Sensor::init() here because init is handled in Encoder class.
208209
}
209210

210211
// function enabling hardware interrupts of the for the callback provided

src/sensors/HallSensor.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ void HallSensor::init(){
166166

167167
pulse_timestamp = _micros();
168168

169+
// we don't call Sensor::init() here because init is handled in HallSensor class.
169170
}
170171

171172
// function enabling hardware interrupts for the callback provided

src/sensors/MagneticSensorAnalog.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ MagneticSensorAnalog::MagneticSensorAnalog(uint8_t _pinAnalog, int _min_raw_coun
2424

2525
void MagneticSensorAnalog::init(){
2626
raw_count = getRawCount();
27+
28+
this->Sensor::init(); // call base class init
2729
}
2830

2931
// Shaft angle calculation

src/sensors/MagneticSensorI2C.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ void MagneticSensorI2C::init(TwoWire* _wire){
6464

6565
// I2C communication begin
6666
wire->begin();
67+
68+
this->Sensor::init(); // call base class init
6769
}
6870

6971
// Shaft angle calculation

src/sensors/MagneticSensorPWM.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ void MagneticSensorPWM::init(){
2727
// initial hardware
2828
pinMode(pinPWM, INPUT);
2929
raw_count = getRawCount();
30+
31+
this->Sensor::init(); // call base class init
3032
}
3133

3234
// get current angle (rad)

src/sensors/MagneticSensorSPI.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ void MagneticSensorSPI::init(SPIClass* _spi){
7474
// do any architectures need to set the clock divider for SPI? Why was this in the code?
7575
//spi->setClockDivider(SPI_CLOCK_DIV8);
7676
digitalWrite(chip_select_pin, HIGH);
77+
78+
this->Sensor::init(); // call base class init
7779
}
7880

7981
// Shaft angle calculation

0 commit comments

Comments
 (0)