esp32 nano insists on 3 parameters for pulseIn

Richard Unger · Richard Unger · commit a163d144fd2c · 2023-08-21T23:03:24.000+02:00
diff --git a/src/sensors/MagneticSensorPWM.cpp b/src/sensors/MagneticSensorPWM.cpp
@@ -85,7 +85,7 @@ float MagneticSensorPWM::getSensorAngle(){
 int MagneticSensorPWM::getRawCount(){
     if (!is_interrupt_based){ // if it's not interrupt based read the value in a blocking way
         pulse_timestamp = _micros(); // ideally this should be done right at the rising edge of the pulse
-        pulse_length_us = pulseIn(pinPWM, HIGH);
+        pulse_length_us = pulseIn(pinPWM, HIGH, 1200); // 1200us timeout, should this be configurable?
     }
     return pulse_length_us;
 }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ float MagneticSensorPWM::getSensorAngle(){`
`85`	`85`	`int MagneticSensorPWM::getRawCount(){`
`86`	`86`	`if (!is_interrupt_based){ // if it's not interrupt based read the value in a blocking way`
`87`	`87`	`pulse_timestamp = _micros(); // ideally this should be done right at the rising edge of the pulse`
`88`		`- pulse_length_us = pulseIn(pinPWM, HIGH);`
	`88`	`+ pulse_length_us = pulseIn(pinPWM, HIGH, 1200); // 1200us timeout, should this be configurable?`
`89`	`89`	`}`
`90`	`90`	`return pulse_length_us;`
`91`	`91`	`}`