This repository was archived by the owner on Feb 22, 2019. It is now read-only.
Fix thrift negative integer handling.#143
Open
muirmanders wants to merge 1 commit intosimplereach:masterfrom
Open
Fix thrift negative integer handling.#143muirmanders wants to merge 1 commit intosimplereach:masterfrom
muirmanders wants to merge 1 commit intosimplereach:masterfrom
Conversation
Use the node-int64 package to handle serializing/deserializing 64-bit signed integers. Also, you will now get an error if you try to fetch out integer values that would lose precision in javascript. Fix 32-bit signed int serialization also (was using writeUInt32BE instead of writeInt32BE).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the node-int64 package to handle serializing/deserializing
64-bit signed integers. Also, you will now get an error if you
try to fetch out integer values that would lose precision in
javascript.
Fix 32-bit signed int serialization also (was using writeUInt32BE
instead of writeInt32BE).