Skip to content

Conversation

@cicnavi
Copy link
Collaborator

@cicnavi cicnavi commented Feb 7, 2025

Closes #184

@cicnavi cicnavi changed the title Enable defining additional private / t pairs for key rollover scenarios Enable defining additional private / public key pair for key rollover scenario Feb 7, 2025
@cicnavi cicnavi requested a review from tvdijen February 7, 2025 10:36
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 74.07407% with 14 lines in your changes missing coverage. Please review.

Project coverage is 50.65%. Comparing base (444968f) to head (10f811d).

Files with missing lines Patch % Lines
src/ModuleConfig.php 0.00% 13 Missing ⚠️
src/Services/JsonWebKeySetService.php 97.56% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             wip-version-6     #283      +/-   ##
===================================================
+ Coverage            50.46%   50.65%   +0.19%     
- Complexity            1471     1479       +8     
===================================================
  Files                  146      146              
  Lines                 6385     6420      +35     
===================================================
+ Hits                  3222     3252      +30     
- Misses                3163     3168       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cicnavi cicnavi merged commit d22585d into wip-version-6 Feb 7, 2025
14 checks passed
@cicnavi cicnavi deleted the wip-version-6-key-rollover branch February 7, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants