Make sub claim value single value only #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In custom scopes, one can also use standard claims. Custom scopes have an option to allow a claim to have multiple values. Standard claims have predefined format, as per https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims.
OIDC module expects certain claims to have single value (for example,
subclaim). Setting it to multi value brakes the app. This PR solves that.Note: this PR only solves the
subclaim, while the other user claims will be resolved in v7 branch, since this can potentially be a breaking change (one can set standard claim as multi value in custom scope, and the OIDC module wouldn't mind, as it doesn't reference them in code).Closes #308