Skip to content

Conversation

@cicnavi
Copy link
Collaborator

@cicnavi cicnavi commented Jun 9, 2025

In custom scopes, one can also use standard claims. Custom scopes have an option to allow a claim to have multiple values. Standard claims have predefined format, as per https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims.
OIDC module expects certain claims to have single value (for example, sub claim). Setting it to multi value brakes the app. This PR solves that.

Note: this PR only solves the sub claim, while the other user claims will be resolved in v7 branch, since this can potentially be a breaking change (one can set standard claim as multi value in custom scope, and the OIDC module wouldn't mind, as it doesn't reference them in code).

Closes #308

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.62%. Comparing base (0080cf2) to head (0777e28).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #309      +/-   ##
============================================
+ Coverage     53.53%   53.62%   +0.08%     
- Complexity     1488     1489       +1     
============================================
  Files           141      141              
  Lines          6459     6460       +1     
============================================
+ Hits           3458     3464       +6     
+ Misses         3001     2996       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrvanes
Copy link
Collaborator

mrvanes commented Jun 10, 2025

Tested and fixes #308

@cicnavi cicnavi merged commit be9cc74 into master Jun 10, 2025
15 checks passed
@cicnavi cicnavi deleted the fix/multival branch June 10, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal representation of all attributes are arrays but module-oidc references them as string

3 participants