Skip to content

Conversation

@cicnavi
Copy link
Collaborator

@cicnavi cicnavi commented Nov 21, 2025

Initial OpenID4VCI support

cicnavi and others added 27 commits September 10, 2025 11:57
Separate the VC issuer from authorization server. The `issuer_state` is not checked in the authorization endpoint anymore, but simply accepted as an opaque identifier and afterwards reflected in the access token. The issuer can compare the previously offered `issuer_state` against the `issuer_state` in the access token.

---------

Co-authored-by: Marko Ivančić <[email protected]>
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 8.89908% with 1986 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.38%. Comparing base (e779e59) to head (5e268a8).
⚠️ Report is 1 commits behind head on wip-version-7.

Files with missing lines Patch % Lines
...edentials/CredentialIssuerCredentialController.php 0.00% 379 Missing ⚠️
src/Server/Grants/AuthCodeGrant.php 0.00% 150 Missing ⚠️
src/Factories/CredentialOfferUriFactory.php 0.00% 147 Missing ⚠️
src/Server/RequestRules/Rules/ClientRule.php 11.87% 141 Missing ⚠️
...ontrollers/Api/VciCredentialOfferApiController.php 0.00% 114 Missing ⚠️
src/Services/DatabaseMigration.php 0.00% 106 Missing ⚠️
src/Server/Grants/PreAuthCodeGrant.php 0.00% 97 Missing ⚠️
...lers/Admin/VerifiableCredentailsTestController.php 0.00% 87 Missing ⚠️
src/Repositories/IssuerStateRepository.php 0.00% 82 Missing ⚠️
src/ModuleConfig.php 10.11% 80 Missing ⚠️
... and 45 more
Additional details and impacted files
@@                 Coverage Diff                  @@
##             wip-version-7     #322       +/-   ##
====================================================
- Coverage            53.79%   42.38%   -11.41%     
- Complexity            1500     1892      +392     
====================================================
  Files                  141      160       +19     
  Lines                 6058     7981     +1923     
====================================================
+ Hits                  3259     3383      +124     
- Misses                2799     4598     +1799     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cicnavi cicnavi merged commit ddb0f88 into wip-version-7 Nov 21, 2025
14 of 16 checks passed
@cicnavi cicnavi deleted the wip-vci branch November 21, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants