Skip to content
This repository was archived by the owner on Oct 18, 2022. It is now read-only.

Comments

Add project quality checklist#9

Open
tompluess wants to merge 5 commits intomasterfrom
doc-quality
Open

Add project quality checklist#9
tompluess wants to merge 5 commits intomasterfrom
doc-quality

Conversation

@tompluess
Copy link
Contributor

@tompluess tompluess commented Mar 14, 2019

This PR is a proposal of how we could implement quality assurance in our projects.

any alternative proposals are welcome!

@tompluess tompluess self-assigned this Mar 14, 2019
@lukaseppler
Copy link
Member

Suggesting to put this in a doc folder instead of root.

@tompluess
Copy link
Contributor Author

Suggesting to put this in a doc folder instead of root.

👍 done.

@ghost ghost self-requested a review March 18, 2019 10:10
Copy link

@crackofdusk crackofdusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my mind this is not something you copy to every project.

The workflow I imagine is you do some of these things during the initial setup (static analysis, deployment, monitoring, moco, trello, server access, backups). The rest comes later one (tests, documentation), but you check at certain milestones if the project adheres to the original/single source of the checklist.

For example, I would expect that there is a ticket in the backlog about going through the checklist and adding missing documentation.

@tompluess
Copy link
Contributor Author

In my mind this is not something you copy to every project.

The workflow I imagine is you do some of these things during the initial setup (static analysis, deployment, monitoring, moco, trello, server access, backups). The rest comes later one (tests, documentation), but you check at certain milestones if the project adheres to the original/single source of the checklist.

For example, I would expect that there is a ticket in the backlog about going through the checklist and adding missing documentation.

I agree that there should be tasks in the backlog about doing the items on the checklist.

If we do not have the checklist itself under source control, how would we then see on one sight where we are regarding our expected quality tasks, and especially what's missing?

@crackofdusk
Copy link

If we do not have the checklist itself under source control, how would we then see on one sight where we are regarding our expected quality tasks, and especially what's missing?

The idea would be to go through all items again and check whether they are up-to-date (maybe the charta checklist changed in the meantime?)

Furthermore, the outcome of many items is a sentence or a section in the readme. A well-written and well-structured readme will provide you a quick overview by means of its form.

For example, in the current pull request, instead of adding a copy of the checklist, I would add the following to the readme:

  • a link to the semaphore pipeline page at the top;
  • a "Deployment" section which explains that staging is automatically deployed and where that is configured (.semaphore/semaphore.yml) in case one wants to, say, make that a manual step or add a new environment.

This way, next time I go over the checklist in the charta, I can easily see there is a deployment pipeline and check on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants