Open
Conversation
boddumanohar
force-pushed
the
run-as-non-root
branch
from
df509eb to
7da14a3
Compare
boddumanohar
force-pushed
the
run-as-non-root
branch
from
7da14a3 to
d0b6b46
Compare
boddumanohar
force-pushed
the
run-as-non-root
branch
from
d0b6b46 to
298af63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All containers use root as their user, even unpriviledged ones, which is against Kubernetes best practices and doesn’t work on OpenShift
Also
Deployment descriptors do not define an SCC (security context constraint). This should at least be a valid variable to be passed into the template rendering for all containers.
Successful e2e test run:
https://github.com/simplyblock-io/simplyBlockDeployGCP/actions/runs/16492760187