use simplyblock v2 API to contact storage backend#292
Merged
boddumanohar merged 4 commits intomainfrom Nov 24, 2025
Merged
Conversation
mxsrc
requested changes
Nov 20, 2025
Collaborator
mxsrc
left a comment
There was a problem hiding this comment.
I like this, but ideally we make the API module more self-contained, s.t. we can more easily replace it with a generated one. I think a good way would be to export a class that offers the pool() and volume_iostats() functions.
4ff4433 to
17a67e1
Compare
17a67e1 to
a2246e3
Compare
ecf7e8d to
a436cad
Compare
mxsrc
requested changes
Nov 24, 2025
Collaborator
mxsrc
left a comment
There was a problem hiding this comment.
Thanks, this is much nicer already! I think we should make the SimplyblockApi class a bit more powerful, that would improve usage even more.
Member
Author
|
The linter failure (helm charts) seems un-related to the changes in the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, we contact Simplyblock storage API at 2 places:
MODIFY_VOLUMEfeature yet. This WIP in implement controller Modify Volume simplyblock-csi#243As a part of this PR, I've extracted simplyblock related code to a common utils. and used it at both the above 2 places
The format of the response returned by IO Stats API is: