Merged
Conversation
boddumanohar
force-pushed
the
setup-iops-using-volumeattr-class
branch
from
d5b17fc to
efe8e6d
Compare
boddumanohar
force-pushed
the
setup-iops-using-volumeattr-class
branch
from
efe8e6d to
091c969
Compare
noctarius
approved these changes
Oct 21, 2025
Collaborator
noctarius
left a comment
noctarius
left a comment
There was a problem hiding this comment.
I can't really give feedback to the logic and I assume you tested it. This is a horrible hack and I wonder if we should document those hacks somewhere so they don't stay 😅
Member
Author
|
Yeah, the changes are tested and are working for both create branch and resize branch. I confirmed them by checking the field |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting IOPS during the initial branch create:
sc-<branch-id>and then pass it as a part of helm chart.Resizing IOPS:
Ideally we should be using the CSI driver to support perform the IOPS resize using volume attributes class. But our CSI driver doesn't support MODIFY_VOLUME operation. This should be ideally supported as a part of the PR: simplyblock/simplyblock-csi#243. But due to the lack of time, I couldn't work on this PR right now.
So we call the storage cluster and update the IOPS directly.
Source.VolumeAttributes.uuidand this IOPS update status can also be seen in
resize_statuses. We set the resize IOPS state as done we receive a 2XX response from the storage backend API.