Close previously open code action windows

[dodomorandi]

This should fix an issue that can be triggered when the LSP is slow for any reason. Now the code
simply tries to cleanup primary and secondary windows before opening new ones.

I also removed the geometry from the secondary state, because it is not needed anywhere else than
the function where the value is created.

@PPakalns could you check if this fixes your issue?

Closes #362

[MunifTanjim]

Following the steps from #362, now the second code action picker doesn't open at all.

[dodomorandi]

Do you mean that this is expected for you or you wanted a different behavior?

I tried to avoid multiple code actions opened, which has the consequence that when the LSP is still loading the stuck before trying to open the floats. Which leads to undetermined order of resolution for the handling of the cleanup state. For instance, during my tests I saw no code action windows opening, which to me is still better than the previous behavior.

Let me know if this approach is ok or if you would rather opt for something different ☺️.

[MunifTanjim]

It should follow the native neovim behavior of vim.lsp.buf.code_action?

• Only once code action menu can be opened at once
• If you move focus out of the action menu, it will close automatically
• If you somehow trigger a new code action menu (when one is already open), the previous one will close and the new one will get opened.

🤔

[dodomorandi]

Ok, I think I got your point: you should be able to close the previous code action instead of avoiding the opening of a new one, right?

I did not thing about this kind of situation because if you run vim.lsp.buf.code_action you natively don't get any window, you just get the input message to choose the code action, you cannot open a new action code without leaving (and making disappear) the current choice.

In any case, I simply did not realize that if you just focus out of the floating window (instead of quitting it), it will just be left there and if you try to open a new code action both are closed. But also think that the problem is I mainly related to your second point, not the third one. In other words, I think that it should not be possible to trigger a second code action without the first one already been closed.

Do we agree? As I said, I was not really understanding because "focusing out" was just "quitting" the floating window, now I also think that the issue is still there.

[dodomorandi]

@MunifTanjim I added two events listener in order to detect when the code action windows are left, in order to close them. Interestingly enough, I started noticing a different issue if you try to repeatedly open a code action when the LSP is still not ready, maybe related to the fact that state.actions is cleared on cleanup (which I run in case when leaving the code action windows) but there are concurrent handling of pending code actions.

Let me know what you think, for both the change and the new issue. Said that, I noticed what you are doing for this project and I really appreciate it. So, thank you for your efforts.