-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improvement(logs): surface integration triggers in logs instead of catchall 'webhook' trigger type #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR replaces the generic 'webhook' trigger type with specific integration names (e.g., 'Linear', 'Slack', 'GitHub') throughout the logs system, providing better visibility into which integrations triggered workflow executions. Key Changes:
Issues Found:
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant W as Webhook Provider
participant P as WebhookProcessor
participant T as Trigger.dev Task
participant E as webhook-execution.ts
participant L as LoggingSession
participant DB as Database
participant U as Logs UI
participant A as /api/logs/triggers
participant M as get-trigger-options.ts
Note over W,P: Webhook Execution Flow
W->>P: POST /api/webhooks/trigger/[path]
P->>P: Verify auth & parse payload
P->>P: Create payload with provider field
Note right of P: provider: 'linear', 'slack', etc.
alt Trigger.dev enabled
P->>T: tasks.trigger('webhook-execution', payload)
T->>E: executeWebhookJob(payload)
else Direct execution
P->>E: executeWebhookJob(payload)
end
E->>L: new LoggingSession(workflowId, executionId, provider)
Note right of L: Uses payload.provider as trigger type
E->>E: Execute workflow blocks
L->>DB: Insert log with trigger = provider
Note right of DB: Stored as 'linear', 'slack', etc.<br/>instead of 'webhook'
Note over U,M: Logs UI Display Flow
U->>A: GET /api/logs/triggers?workspaceId=...
A->>DB: SELECT DISTINCT trigger WHERE trigger NOT IN (core types)
DB-->>A: ['linear', 'slack', 'github', ...]
A->>M: getIntegrationMetadata(trigger)
M->>M: Map to block name & color
A-->>U: [{value: 'linear', label: 'Linear', color: '#...'}]
U->>U: Display triggers with colors in filters
U->>U: Display triggers in search suggestions
U->>U: Display trigger badges in logs table
U->>U: Display trigger in sidebar
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
apps/sim/app/workspace/[workspaceId]/logs/components/search/search.tsx
Outdated
Show resolved
Hide resolved
…tchall 'webhook' trigger type (simstudioai#2102) * improvement(logs): surface integration triggers in logs instead of catchall * optimized calculation, added new triggers to search * cleanup * fix console log
Summary
Linearinstead ofwebhook)Type of Change
Testing
Tested manually
Checklist