Skip to content

Conversation

@emir-karabeg
Copy link
Collaborator

Summary

This PR fixes a bug where the displayed webhook URL would change after a webhook trigger was created and its data loaded from the API. Previously, the URL was initially computed using blockId as a fallback, but would reactively update if the triggerPath (from the loaded webhook data) differed. This caused instability and broke external integrations.

The fix ensures the webhook URL is always consistently computed using the blockId, making it stable from creation and preventing unexpected changes.

Fixes # (issue) - [Bug] I added a slack trigger from scratch. At some point, the webhook URL changed.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

The changes involve simplifying the webhook URL computation to always use blockId. Reviewers should focus on ensuring that this consistent use of blockId for the webhook URL display aligns with how webhooks are created and handled in the backend, and that no other components rely on the triggerPath for URL display.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos


Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Dec 19, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Dec 19, 2025 11:53pm

@waleedlatif1 waleedlatif1 deleted the cursor/slack-webhook-url-fix-b5ff branch December 20, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants