Skip to content

Conversation

@emir-karabeg
Copy link
Collaborator

Summary

Fixes a bug where conditional subblock parameters (like branchName in the Cursor block) were not being included in the serialized block configuration if the conditioning field's stored value was null, even when that field had a default value function that would satisfy the condition.

The issue stemmed from default values not being applied to allValues before condition evaluation in the serializer's extractParams function.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

The existing test suite was run and passed. A new test case was added to apps/sim/serializer/index.test.ts to specifically cover the scenario where a conditional field's inclusion depends on a conditioning field with a default value.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos


Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Dec 20, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vercel
Copy link

vercel bot commented Dec 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Dec 20, 2025 0:17am

@emir-karabeg emir-karabeg reopened this Dec 20, 2025
@waleedlatif1 waleedlatif1 deleted the cursor/branch-name-null-bug-3ef8 branch December 20, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants