Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where conditional subblock parameters (like
branchNamein the Cursor block) were not being included in the serialized block configuration if the conditioning field's stored value wasnull, even when that field had a default value function that would satisfy the condition.The issue stemmed from default values not being applied to
allValuesbefore condition evaluation in the serializer'sextractParamsfunction.Type of Change
Testing
The existing test suite was run and passed. A new test case was added to
apps/sim/serializer/index.test.tsto specifically cover the scenario where a conditional field's inclusion depends on a conditioning field with a default value.Checklist
Screenshots/Videos