Conversation
…o absolute kindle page position. Untested.
…y too far, beyond where we are in the buffer.
…adding jump bool to know if we need to jump ahead becuase user navigated while waiting on server.
… internal page count.
…can happen, moving threshold out to 1500.
… NVM so we don't rewrite kindle.json on every page turn.
…ningful and there's no way to prevent distortion without a test-only callback.
johnboiles
left a comment
There was a problem hiding this comment.
instead we could treat locations like Sol EPUB bytes and divide them by 1000 and get a ~Sol page number. WDYT
To me it depends on whether Kindle locations are consistent. Does it seem to roughly correlate with the amount of text?
|
To be clear (since there's a lot to parse above), I propose we don't show For the "Rich Men" article, native EPUB would show Or should it say Location and not convert at all? The full |
|
I'm going to punt on handling location and just get pages working for books that support it. |
…t read page..." dialog screenshots. It fails intermittently with these two, even though the images come back correct.
|
Servers already giving these page numbers, and since we're now public, this gets merged. |





Page X of Y. This is more of a server-side change than client, but apart from turning it on, I had to handle compatibility with regular readables.
Note that we don't show a page number when the server returns locations instead of pages, which happens on more EPUBs than I would have thought. Kindle is stricter about EPUB page numbers, so instead we could treat locations like Sol EPUB bytes and divide them by 1000 and get a ~Sol page number. WDYT?