Update view tests to the new pattern everywhere

[johnboiles]

Hopefully this makes view tests more reliable.

I decided to change the pattern from #1155 to instead have WAIT_FOR_DRAW take an optional parameter that determines whether the UI continues to run after. After a weekend of thinking about it I liked this better because then WAIT_FOR_DRAW is the only place that we wait for a draw to occur. It felt a little funky to me to combine WAIT_FOR_DRAW into ASSERT_VIEW_UNCHANGED but only sometimes.

I did this mostly with regexes:

1. Find the recent new style used only in Kindle tests

   ASSERT_VIEW_UNCHANGED\(display, "([a-zA-Z0-9-_.]*)", true\);
   

   Replace with

   WAIT_FOR_DRAW(display, false);
   ASSERT_VIEW_UNCHANGED(display, "$1");
   

2. Find WAIT_FOR_DRAW with ASSERT_VIEW_UNCHANGED afterwards

   (^[ ]*)WAIT_FOR_DRAW\(display\);([\s\n]*)ASSERT_VIEW_UNCHANGED
   

   Replace with

   $1WAIT_FOR_DRAW(display, false);$2ASSERT_VIEW_UNCHANGED
   

3. Sanity check lines with WAIT_FOR_DRAW not followed by ASSERT_VIEW_UNCHANGED or WAIT_FOR_DRAW

   (^[ ]*)WAIT_FOR_DRAW\(display\);[\s\n]*(?!ASSERT_VIEW_UNCHANGED|\s|WAIT_FOR_DRAW)
   

   Check and cleanup manually