Conversation
|
Hi @YuzeHao2023, thanks for the submission! I've reviewed your list against the awesome guidelines. It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. the Owner spent a lot of time creating the guidelines so we wouldn't have to comment on common mistakes. License: You are using Apache-2.0. Awesome lists must use a content license (preferably CC0). Code licenses (MIT/Apache) are not accepted. Repo Name: Rename your repository to awesome-mcp-servers. It must be lowercase slug format. 🛠️ Awesome-Lint & Formatting Issues Required: - Name - Description. (Note the dash separators and markdown link). Descriptions: Every item needs a short, objective description that starts with an uppercase letter and ends with a period. Many of your items are missing descriptions entirely. Table of Contents: Rename the section Server Implementations to exactly Contents. It must be the first section after the header. Missing Files: You are missing a contributing.md file. Content review: Reference Servers: The "Reference Servers" section is confusing. If these are examples, consider moving them to a "Tutorials" or "Examples" section rather than mixing them with production tools. Link Hygiene: Ensure all links go to the specific project/readme, not just a generic profile or tree root unless necessary. 📝 Mandatory PR Actions Once you have fixed the above,reviewed others and read the PR guidelines then comment unicorn on this PR to confirm compliance. |
|
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
bad-antics
left a comment
There was a problem hiding this comment.
PR needs work - the checklist is not completed (all boxes unchecked), no description provided, and the placeholder text '[Explain what this list is about...]' remains. Also missing the required 2 PR reviews. Please follow the awesome submission guidelines.
|
Checklist not completed in review - follow guidelines |
[Insert URL to the list here]
[Explain what this list is about and why it should be included here]
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List. It should not contain the wordAwesome.Add SwiftAdd Software ArchitectureUpdate readme.mdAdd Awesome SwiftAdd swiftadd SwiftAdding SwiftAdded Swift- [iOS](…) - Mobile operating system for Apple phones and tablets.- [Framer](…) - Prototyping interactive UI designs.- [iOS](…) - Resources and tools for iOS development.- [Framer](…)- [Framer](…) - prototyping interactive UI designs#readme.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-linton your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main, notmaster.Mobile operating system for Apple phones and tablets.Prototyping interactive UI designs.Resources and tools for iOS development.Awesome Framer packages and tools.If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list.awesome-swiftawesome-web-typographyawesome-SwiftAwesomeWebTypography# Awesome Name of List.# Awesome Swift# Awesome Web Typography# awesome-swift# AwesomeSwiftawesome-list&awesomeas GitHub topics. I encourage you to add more relevant topics.Awesome Xand a logo withAwesome X. You can put the header image in a#(Markdown header) or<h1>.Contents, notTable of Contents.ContributingorFootnotessections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0(replace<user>and<repo>accordingly).licenseorLICENSEin the repo root with the license text.Licencesection to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn.contributing.md. The casing is up to you.Contributing, positioned at the top or bottom of the main content.Footnotessection at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.Node.js, notNodeJSornode.js.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-fooorInspired by the Awesome projectkinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.