Conversation
Adding 'Agent Skills' to the Miscellaneous section.
|
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
|
I am sure you've already done so, but definitely recommend using https://github.com/sindresorhus/awesome-lint It solved a lot of the basic issues with a list I am preparing to PR. GL! |
|
In addition I notice your PR didn't replace the placeholder content at the top like replacing [Insert URL to the list here] with https://github.com/skillmatic-ai/awesome-agent-skills |
|
@xxl007 Thanks for the contribution! I reviewed this PR and found several issues that need to be addressed. Critical Issues
Action required:
The repository itself looks well-structured otherwise with proper license, contributing guidelines, and topics. Once these issues are fixed, this should be ready to merge. Please run |
bad-antics
left a comment
There was a problem hiding this comment.
PR is incomplete - placeholder text '[Insert URL to the list here]' and '[Explain what this list is about...]' remain unfilled. Need the actual list URL and description. Please update the PR with the required information.
|
unicorn |
|
You should review two PRs |
Adding 'Agent Skills' to the Miscellaneous section.
https://github.com/skillmatic-ai/awesome-agent-skills
Agent Skills is an open standard for giving agents new capabilities and expertise. This list is intended for orienting AI engineers who want to learn about this standard. A such a comprehensive and independently curated resource does not exist yet on this particular topic.
PRs reviewed:
#3732
#3733
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List. It should not contain the wordAwesome.Add SwiftAdd Software ArchitectureUpdate readme.mdAdd Awesome SwiftAdd swiftadd SwiftAdding SwiftAdded Swift- [iOS](…) - Mobile operating system for Apple phones and tablets.- [Framer](…) - Prototyping interactive UI designs.- [iOS](…) - Resources and tools for iOS development.- [Framer](…)- [Framer](…) - prototyping interactive UI designs#readme.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-linton your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main, notmaster.Mobile operating system for Apple phones and tablets.Prototyping interactive UI designs.Resources and tools for iOS development.Awesome Framer packages and tools.If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list.awesome-swiftawesome-web-typographyawesome-SwiftAwesomeWebTypography# Awesome Name of List.# Awesome Swift# Awesome Web Typography# awesome-swift# AwesomeSwiftawesome-list&awesomeas GitHub topics. I encourage you to add more relevant topics.Awesome Xand a logo withAwesome X. You can put the header image in a#(Markdown header) or<h1>.Contents, notTable of Contents.ContributingorFootnotessections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0(replace<user>and<repo>accordingly).licenseorLICENSEin the repo root with the license text.Licencesection to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn.contributing.md. The casing is up to you.Contributing, positioned at the top or bottom of the main content.Footnotessection at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.Node.js, notNodeJSornode.js.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-fooorInspired by the Awesome projectkinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.