Reuse existing AST check utilities (#2650)

Author: fisker

rules/prefer-at.js

@@ -17,7 +17,12 @@ import {
 	removeLengthNode,
 } from './shared/negative-index.js';
 import {removeMemberExpressionProperty, removeMethodCall} from './fix/index.js';
-import {isLiteral, isCallExpression, isMethodCall} from './ast/index.js';
+import {
+	isLiteral,
+	isCallExpression,
+	isMethodCall,
+	isMemberExpression,
+} from './ast/index.js';
 
 const MESSAGE_ID_NEGATIVE_INDEX = 'negative-index';
 const MESSAGE_ID_INDEX = 'index';
@@ -45,28 +50,22 @@ const isLiteralNegativeInteger = node =>
 	&& node.argument.type === 'Literal'
 	&& Number.isInteger(node.argument.value)
 	&& node.argument.value > 0;
-const isZeroIndexAccess = node => {
-	const {parent} = node;
-	return parent.type === 'MemberExpression'
-		&& !parent.optional
-		&& parent.computed
-		&& parent.object === node
-		&& isLiteral(parent.property, 0);
-};
-
-const isArrayPopOrShiftCall = (node, method) => {
-	const {parent} = node;
-	return parent.type === 'MemberExpression'
-		&& !parent.optional
-		&& !parent.computed
-		&& parent.object === node
-		&& parent.property.type === 'Identifier'
-		&& parent.property.name === method
-		&& parent.parent.type === 'CallExpression'
-		&& parent.parent.callee === parent
-		&& !parent.parent.optional
-		&& parent.parent.arguments.length === 0;
-};
+const isZeroIndexAccess = node =>
+	isMemberExpression(node.parent, {
+		optional: false,
+		computed: true,
+	})
+	&& node.parent.object === node
+	&& isLiteral(node.parent.property, 0);
+
+const isArrayPopOrShiftCall = (node, method) =>
+	isMethodCall(node.parent.parent, {
+		method,
+		argumentsLength: 0,
+		optionalCall: false,
+		optionalMember: false,
+	})
+	&& node.parent.object === node;
 
 const isArrayPopCall = node => isArrayPopOrShiftCall(node, 'pop');
 const isArrayShiftCall = node => isArrayPopOrShiftCall(node, 'shift');

rules/prefer-set-has.js

@@ -27,21 +27,14 @@ const arrayMethodsReturnsArray = [
 	'with',
 ];
 
-const isIncludesCall = node => {
-	const {type, optional, callee, arguments: includesArguments} = node.parent.parent ?? {};
-	return (
-		type === 'CallExpression'
-		&& !optional
-		&& callee.type === 'MemberExpression'
-		&& !callee.computed
-		&& !callee.optional
-		&& callee.object === node
-		&& callee.property.type === 'Identifier'
-		&& callee.property.name === 'includes'
-		&& includesArguments.length === 1
-		&& includesArguments[0].type !== 'SpreadElement'
-	);
-};
+const isIncludesCall = node =>
+	isMethodCall(node.parent.parent, {
+		method: 'includes',
+		optionalCall: false,
+		optionalMember: false,
+		argumentsLength: 1,
+	})
+	&& node.parent.object === node;
 
 const multipleCallNodeTypes = new Set([
 	'ForOfStatement',

rules/text-encoding-identifier-case.js

@@ -1,4 +1,5 @@
 import {replaceStringRaw} from './fix/index.js';
+import {isMethodCall} from './ast/index.js';
 
 const MESSAGE_ID_ERROR = 'text-encoding-identifier/error';
 const MESSAGE_ID_SUGGESTION = 'text-encoding-identifier/suggestion';
@@ -24,15 +25,13 @@ const getReplacement = encoding => {
 
 // `fs.{readFile,readFileSync}()`
 const isFsReadFileEncoding = node =>
-	node.parent.type === 'CallExpression'
-	&& !node.parent.optional
+	isMethodCall(node.parent, {
+		methods: ['readFile', 'readFileSync'],
+		optionalCall: false,
+		optionalMember: false,
+	})
 	&& node.parent.arguments[1] === node
-	&& node.parent.arguments[0].type !== 'SpreadElement'
-	&& node.parent.callee.type === 'MemberExpression'
-	&& !node.parent.callee.optional
-	&& !node.parent.callee.computed
-	&& node.parent.callee.property.type === 'Identifier'
-	&& (node.parent.callee.property.name === 'readFile' || node.parent.callee.property.name === 'readFileSync');
+	&& node.parent.arguments[0].type !== 'SpreadElement';
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = () => ({