fix (prefer-bigint-literals): fix add support for numbers/strings with operators

rules/prefer-bigint-literals.js

@@ -10,15 +10,13 @@ const messages = {
 	[MESSAGE_ID_SUGGESTION]: 'Replace with {{replacement}}.',
 };
 
-const canUseNumericLiteralRaw = numericLiteral => {
-	const raw = numericLiteral.raw.replaceAll('_', '').toLowerCase();
+const canUseNumericLiteralRaw = (value, nodeRaw) => {
+	const raw = nodeRaw.replaceAll('_', '').toLowerCase();
 
 	if (raw.includes('.')) {
 		return false;
 	}
 
-	const {value} = numericLiteral;
-
 	for (const {prefix, base} of [
 		{prefix: '0b', base: 2},
 		{prefix: '0o', base: 8},
@@ -36,19 +34,32 @@ const canUseNumericLiteralRaw = numericLiteral => {
 	return raw === String(value);
 };
 
+function getValueOfNode(valueNode) {
+	if (valueNode.type === 'UnaryExpression' && (valueNode.operator === '+' || valueNode.operator === '-')) {
+		return valueNode.operator === '+' ? {value: valueNode.argument.value, raw: valueNode.argument.raw} : {value: -valueNode.argument.value, raw: `-${valueNode.argument.raw}`};
+	}
+
+	return {value: valueNode.value, raw: valueNode.raw};
+}
+
 function getReplacement(valueNode) {
 	if (isStringLiteral(valueNode)) {
-		const raw = valueNode.raw.slice(1, -1);
+		let raw = valueNode.raw.slice(1, -1);
 		try {
 			BigInt(raw);
 		} catch {
 			return;
 		}
 
+		// BigInt("+1") -> 1n
+		if (raw[0] === '+') {
+			raw = raw.slice(1);
+		}
+
 		return {shouldUseSuggestion: false, text: `${raw.trimEnd()}n`};
 	}
 
-	const {value, raw} = valueNode;
+	const {value, raw} = getValueOfNode(valueNode);
 
 	if (!Number.isInteger(value)) {
 		return;
@@ -61,7 +72,7 @@ function getReplacement(valueNode) {
 		return;
 	}
 
-	const shouldUseSuggestion = !canUseNumericLiteralRaw(valueNode);
+	const shouldUseSuggestion = !canUseNumericLiteralRaw(value, raw);
 	const text = shouldUseSuggestion ? `${bigint}n` : `${raw}n`;
 	return {shouldUseSuggestion, text};
 }

test/prefer-bigint-literals.js

@@ -25,6 +25,8 @@ test.snapshot({
 		'BigInt("1_2")',
 		'BigInt("1\\\n2")',
 		String.raw`BigInt("\u{31}")`,
+		'BigInt(!1)',
+		'BigInt(~1)',
 	],
 	invalid: [
 		'BigInt("0")',
@@ -52,5 +54,9 @@ test.snapshot({
 		'BigInt(1e2)',
 		'BigInt(/* comment */1)',
 		`BigInt(${'9'.repeat(100)})`,
+		'BigInt("-1")',
+		'BigInt("+1")',
+		'BigInt(-1)',
+		'BigInt(+1)',
 	],
 });

test/snapshots/prefer-bigint-literals.js.md

@@ -424,3 +424,87 @@ Generated by [AVA](https://avajs.dev).
     Suggestion 1/1: Replace with a bigint literal.␊
       1 | 10000000000000000159028911097599180468360808563945281389781327557747838772170381060813469985856815104n␊
     `
+
+## invalid(22): BigInt("-1")
+
+> Input
+
+    `␊
+      1 | BigInt("-1")␊
+    `
+
+> Output
+
+    `␊
+      1 | -1n␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | BigInt("-1")␊
+        | ^^^^^^^^^^^^ Prefer using bigint literal over \`BigInt(…)\`.␊
+    `
+
+## invalid(23): BigInt("+1")
+
+> Input
+
+    `␊
+      1 | BigInt("+1")␊
+    `
+
+> Output
+
+    `␊
+      1 | 1n␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | BigInt("+1")␊
+        | ^^^^^^^^^^^^ Prefer using bigint literal over \`BigInt(…)\`.␊
+    `
+
+## invalid(24): BigInt(-1)
+
+> Input
+
+    `␊
+      1 | BigInt(-1)␊
+    `
+
+> Output
+
+    `␊
+      1 | -1n␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | BigInt(-1)␊
+        | ^^^^^^^^^^ Prefer using bigint literal over \`BigInt(…)\`.␊
+    `
+
+## invalid(25): BigInt(+1)
+
+> Input
+
+    `␊
+      1 | BigInt(+1)␊
+    `
+
+> Output
+
+    `␊
+      1 | 1n␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | BigInt(+1)␊
+        | ^^^^^^^^^^ Prefer using bigint literal over \`BigInt(…)\`.␊
+    `