Fix Node 24-specific deprecation warning#1199
Merged
sindresorhus merged 5 commits intomainfrom May 8, 2025
Merged
Conversation
ehmicky
commented
May 8, 2025
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 11, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.2 | 9.5.3 | ## [v9.5.3](https://github.com/sindresorhus/execa/releases/tag/v9.5.3) - Fix Node 24-specific deprecation warning ([#1199](sindresorhus/execa#1199)) [`1ac5b91`](sindresorhus/execa@1ac5b91) ***
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 17, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.2 | 9.5.3 | ## [v9.5.3](https://github.com/sindresorhus/execa/releases/tag/v9.5.3) - Fix Node 24-specific deprecation warning ([#1199](sindresorhus/execa#1199)) [`1ac5b91`](sindresorhus/execa@1ac5b91) ***
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 18, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.2 | 9.5.3 | ## [v9.5.3](https://github.com/sindresorhus/execa/releases/tag/v9.5.3) - Fix Node 24-specific deprecation warning ([#1199](sindresorhus/execa#1199)) [`1ac5b91`](sindresorhus/execa@1ac5b91) ***
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 24, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.2 | 9.5.3 | ## [v9.5.3](https://github.com/sindresorhus/execa/releases/tag/v9.5.3) - Fix Node 24-specific deprecation warning ([#1199](sindresorhus/execa#1199)) [`1ac5b91`](sindresorhus/execa@1ac5b91) ***
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 25, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.2 | 9.5.3 | ## [v9.5.3](https://github.com/sindresorhus/execa/releases/tag/v9.5.3) - Fix Node 24-specific deprecation warning ([#1199](sindresorhus/execa#1199)) [`1ac5b91`](sindresorhus/execa@1ac5b91) ***
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 31, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.2 | 9.6.0 | ## [v9.6.0](sindresorhus/execa@v9.5.3...a31fe55) ## [v9.5.3](https://github.com/sindresorhus/execa/releases/tag/v9.5.3) - Fix Node 24-specific deprecation warning ([#1199](sindresorhus/execa#1199)) [`1ac5b91`](sindresorhus/execa@1ac5b91) ***
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jun 1, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.2 | 9.6.0 | ## [v9.6.0](sindresorhus/execa@v9.5.3...a31fe55) ## [v9.5.3](https://github.com/sindresorhus/execa/releases/tag/v9.5.3) - Fix Node 24-specific deprecation warning ([#1199](sindresorhus/execa#1199)) [`1ac5b91`](sindresorhus/execa@1ac5b91) ***
|
I'm confused about the purpose of this patch. If someone runs execa("echo", [";rm", "my_precious"], { shell: True })they're going to have a bad time. True, that this patch matches node behavior, but at least node warns. If you're going to suppress the warning, shouldn't you be shell escaping args? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See sindresorhus/nano-spawn#90
This is not a breaking change. This would require a patch release.