Skip to content

Fix CI tests related to .kill(0) #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sindresorhus merged 1 commit into from
Oct 27, 2025
+7 −10
Merged

Fix CI tests related to .kill(0) #1212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions test/return/result.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,13 @@ test('result.isTerminated is false if not killed', async t => {
t.false(isTerminated);
});

// Remove the condition after fixing the bug at https://github.com/sindresorhus/execa/issues/1193
if (!isWindows) {
test('result.isTerminated is false if not killed and subprocess.kill() was called', async t => {
const subprocess = execa('noop.js');
subprocess.kill(0);
t.true(subprocess.killed);
const {isTerminated} = await subprocess;
t.false(isTerminated);
});
}
test('result.isTerminated is false if not killed and subprocess.kill() was called', async t => {
const subprocess = execa('noop.js');
subprocess.kill(0);
t.true(subprocess.killed);
const {isTerminated} = await subprocess;
t.false(isTerminated);
});

test('result.isTerminated is false if not killed, in sync mode', t => {
const {isTerminated} = execaSync('noop.js');
Expand Down