Fix timeout to apply to total operation including retries#825
Merged
sindresorhus merged 1 commit intomainfrom Feb 21, 2026
Merged
Fix timeout to apply to total operation including retries#825sindresorhus merged 1 commit intomainfrom
sindresorhus merged 1 commit intomainfrom
Conversation
sindresorhus
commented
Feb 20, 2026
|
|
||
| // Don't apply jitter when server provides explicit retry timing | ||
| return after < max ? after : max; | ||
| return this.#clampRetryDelayToMax(after); |
Owner
Author
There was a problem hiding this comment.
This is kinda unrelated, but thought I'd fix it while I was touching this code.
sindresorhus
force-pushed
the
fix-timeout
branch
5 times, most recently
from
79264b4 to
429da77
Compare
The `timeout` option now correctly applies to the entire operation including all retry attempts, as documented. Previously, each retry attempt received its own independent timeout. Fixes #784
sindresorhus
force-pushed
the
fix-timeout
branch
from
429da77 to
2a33b80
Compare
sholladay
reviewed
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
timeoutoption now correctly applies to the entire operation including all retry attempts, as documented. Previously, each retry attempt received its own independent timeout.Fixes #784