Upgrade 'xo' to 1.2.3 (from 0.56) and Node to 20.17#83
Open
GrahamLea wants to merge 1 commit intosindresorhus:mainfrom
Open
Upgrade 'xo' to 1.2.3 (from 0.56) and Node to 20.17#83GrahamLea wants to merge 1 commit intosindresorhus:mainfrom
GrahamLea wants to merge 1 commit intosindresorhus:mainfrom
Conversation
xo 0.56 pulled in eslint 8, including deprecated transitive deps rimraf 3, glob 7, inflight, @humanwhocodes/*. xo 1.x moved to eslint 9, resolving those issues, but requiring Node 20. Includes a few small code changes to satisfy new lint rules.
GrahamLea
commented
Mar 16, 2026
| "time-span": "^5.1.0", | ||
| "tsd": "^0.29.0", | ||
| "xo": "^0.56.0" | ||
| "xo": "^1.2.3" |
GrahamLea
commented
Mar 16, 2026
| "sideEffects": false, | ||
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=20.17" |
Author
There was a problem hiding this comment.
Dependency of the new xo version.
GrahamLea
commented
Mar 16, 2026
Comment on lines
+13
to
16
| - 24 | ||
| - 22 | ||
| - 20 | ||
| - 18 | ||
| steps: |
Author
There was a problem hiding this comment.
Test across all current LTS versions.
All other changes are just formatting differences required by bumping up xo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This results in the dependency tree summary moving from 6 high severity vulnerabilities to 3 low severity.
xo 0.56 pulled in eslint 8, including several deprecated transitive deps with security and memory issues.
xo 1.x moved to eslint 9, resolving those issues, but requiring Node 20. (Node 18 went EOL mid last year.)
Bumped CI Node versions matrix to 20, 22, 24.
Includes a few small code changes to satisfy new lint rules in the new xo.