Add intersperse function and Join component#25
Merged
sindresorhus merged 4 commits intomainfrom Sep 9, 2025
Merged
Conversation
Owner
Author
|
// @Richienb |
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
a162e67 to
80b1973
Compare
Richienb
suggested changes
Sep 9, 2025
Co-authored-by: Richie Bendall <richiebendall@gmail.com>
Richienb
suggested changes
Sep 9, 2025
Co-authored-by: Richie Bendall <richiebendall@gmail.com>
Richienb
approved these changes
Sep 9, 2025
Richienb
reviewed
Sep 9, 2025
| ``` | ||
| */ | ||
| export function intersperse( | ||
| children: ReactNode, |
Contributor
There was a problem hiding this comment.
wait, shouldn't this be array?
Richienb
suggested changes
Sep 9, 2025
Contributor
Richienb
left a comment
There was a problem hiding this comment.
can we get some type tests?
Repository owner
deleted a comment
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24