Hide "Næsti hálfleikur" button after advancing to next half#141
Draft
Hide "Næsti hálfleikur" button after advancing to next half#141
Conversation
…to 0 and using halfOffset for clock display Co-authored-by: sindrig <683742+sindrig@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix næsti hálfleikur button functionality
Hide "Næsti hálfleikur" button after advancing to next half
Mar 4, 2026
sindrig
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After clicking "Næsti hálfleikur", the button remained visible because
timeElapsedwas set to the half-stop time (e.g., 45 min), keeping the show condition!started && showInjuryTime && timeElapsed != 0permanently true — making it easy to accidentally skip ahead multiple halves.Root cause
pauseMatch(true)stored the absolute match clock position intimeElapsed, conflating "where is the clock display" with "how much has elapsed this half". The button visibility relied ontimeElapsed != 0as its signal, which was never reset.Changes
halfOffsetfield onMatch— stores the absolute start-of-half offset (e.g., 45 min at start of 2nd half). Parsed from Firebase with fallback to0for backward compatibility.pauseMatch(true)revised — setshalfOffset = halfStops[0] * 60 * 1000and resetstimeElapsed = 0, rather than accumulating intotimeElapsed.milliSecondsElapsed = halfOffset + timeElapsed + (running ? serverTime - started : 0). Clock display is unchanged.isTimeNullupdated —!started && !timeElapsed && !halfOffsetso the clock still shows 45:00 at the start of 2nd half.!!match.timeElapsed; countdown button requires!halfOffsetin addition to!timeElapsed.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.