Open
Conversation
Author
|
supports: #37 |
sinedied
requested changes
Jan 28, 2026
Owner
sinedied
left a comment
sinedied
left a comment
There was a problem hiding this comment.
Thanks for the PR and sorry for the long delay!
Caught a small issue as tags weren't assigned after validation, otherwise looks good!
|
|
||
| const tags: string[] = []; | ||
| try { | ||
| validateTags(remoteData.tag_list.join(', ')); |
Owner
There was a problem hiding this comment.
Suggested change
| validateTags(remoteData.tag_list.join(', ')); | |
| tags = validateTags(remoteData.tag_list.join(', ')); |
| export function validateTags(tags: string): string[] { | ||
| const tagsArray = tags.split(',').map((tag) => tag.trim()); | ||
| const MAX_TAGS = 4; | ||
| const INVALID_TAGS = tagsArray.filter((tag) => !/^[a-z\d-]+$/i.test(tag)); |
Owner
There was a problem hiding this comment.
Suggested change
| const INVALID_TAGS = tagsArray.filter((tag) => !/^[a-z\d-]+$/i.test(tag)); | |
| const invalidTags = tagsArray.filter((tag) => !/^[a-z\d-]+$/i.test(tag)); |
| throw new Error(`Too many tags. Max allowed: ${MAX_TAGS}`); | ||
| } | ||
|
|
||
| if (INVALID_TAGS.length > 0) { |
Owner
There was a problem hiding this comment.
Suggested change
| if (INVALID_TAGS.length > 0) { | |
| if (invalidTags.length > 0) { |
| } | ||
|
|
||
| if (INVALID_TAGS.length > 0) { | ||
| throw new Error(`Invalid tags: ${INVALID_TAGS.join(', ')}`); |
Owner
There was a problem hiding this comment.
Suggested change
| throw new Error(`Invalid tags: ${INVALID_TAGS.join(', ')}`); | |
| throw new Error(`Invalid tags: ${invalidTags.join(', ')}`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.