Open
Conversation
* SAC-29310: Add schema files along with discovery work * Add new-lines in schema json * Review changes * Update schema files and minor code changes for sync * Update datatype of stream key_properties * Update tags data_type in survey_response schema * SAC-29312: Add sync logic for the tap (#2) * SAC-29312: Add sync logic for the tap * Resolve copilot review comments * Update base class for 422 error code * SAC-29515: Add integration tests for tap-delighted (#4) * SAC-29515: Add integration tests for tap-delighted * Resolve PR comments * Resolve Pylint error * Handle timestamp to datetime conversion via transformer * SAC-29515: Update Integration tests (#5) * SAC-29515: Add integration tests for tap-delighted * Resolve PR comments * Adjust page-size for email-autopilot * SAC-29514: Add unittest for the tap (#3) * SAC-29514: Add unittest for the tap * Resolve copilot comments * Remove 422 from retry test * Update unittest without custom datetime parsing * Update CCI config.yml file
* SAC-29310: Add schema files along with discovery work * Add new-lines in schema json * Review changes * Update schema files and minor code changes for sync * Update datatype of stream key_properties * Update tags data_type in survey_response schema * SAC-29312: Add sync logic for the tap * Resolve copilot review comments * Update base class for 422 error code * SAC-29515: Add integration tests for tap-delighted (#4) * SAC-29515: Add integration tests for tap-delighted * Resolve PR comments * Resolve Pylint error * Handle timestamp to datetime conversion via transformer * SAC-29515: Update Integration tests (#5) * SAC-29515: Add integration tests for tap-delighted * Resolve PR comments * Adjust page-size for email-autopilot * SAC-29514: Add unittest for the tap (#3) * SAC-29514: Add unittest for the tap * Resolve copilot comments * Remove 422 from retry test * Update unittest without custom datetime parsing * Update CCI config.yml file * SAC-29312: Add sync logic for the tap (#2) * SAC-29312: Add sync logic for the tap * Resolve copilot review comments * Update base class for 422 error code * SAC-29515: Add integration tests for tap-delighted (#4) * SAC-29515: Add integration tests for tap-delighted * Resolve PR comments * Resolve Pylint error * Handle timestamp to datetime conversion via transformer * SAC-29515: Update Integration tests (#5) * SAC-29515: Add integration tests for tap-delighted * Resolve PR comments * Adjust page-size for email-autopilot * SAC-29514: Add unittest for the tap (#3) * SAC-29514: Add unittest for the tap * Resolve copilot comments * Remove 422 from retry test * Update unittest without custom datetime parsing * Update CCI config.yml file * Update the sync logic as per comment * Resolve conflicts * Resolve Pylint error * Update bookmark format in tests
* Add retry logic for server 5xx errors * Remove 501, 502, 504 from exceptions per API docs * Fix start_date and bookmark tests * Update email_autopilot to test with different start_dates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
(write a short description or paste a link to JIRA)
Manual QA steps
Risks
Rollback steps