Skip to content

Fix json.dumps bug + add fields to schemas#22

Open
pblankley wants to merge 11 commits intosinger-io:masterfrom
Zenlytic:master
Open

Fix json.dumps bug + add fields to schemas#22
pblankley wants to merge 11 commits intosinger-io:masterfrom
Zenlytic:master

Conversation

@pblankley
Copy link

Description of change

Fixes bug with json.dumps in the do_discover function, and adds additional properties to the schemas.

Manual QA steps

  • Ran pipeline end-to-end in a python 3.6 venv

Risks

  • Untested for python 2.7, so possible it won't work for that version.

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants