Open
Conversation
|
Hi @parisholley, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @parisholley! Thank you for signing the Singer Contribution License Agreement. |
|
Hi, This fix would be very useful, any idea on when it could be merged ? Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
see #48
the problem is that the mongo extractor is outputting a SCHEMA for every record, which may be a partial object. when this is consumed by the postgres loader, it fails because the schema keeps getting overwritten and it can't find the
key_properties. i generate a catalog json with my own python script vs relying on this tap to generate it on the fly. i can't say for sure that this is the right solution (perhaps we should write the key_properties every time), but it is the root causeCommand
mongo meltano elt --job_id mongo --catalog transformed.json tap-mongodb target-postgresCatalog
{ "streams": [ { "metadata": [ { "breadcrumb": {}, "metadata": { "database-name": "db", "replication-method": "FULL_TABLE", "selected": true, "tap-mongodb.projection": "{\"_id\": 1, \"name\": 1}" } } ], "schema": { "key_properties": [ "_id" ], "properties": { "_id": { "type": "string" }, "name": { "type": "string" } } } } ] }For those looking for a fix before this is merged, you can use this as your
pip_urlinstead of the standard tap-mongodb package:git+https://github.com/parisholley/tap-mongodb.git@5e5f95649d4705205b654a1b09a533f006e0126e