-
Notifications
You must be signed in to change notification settings - Fork 6
Added unit and integration test cases #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive test coverage for the MS Teams tap by introducing unit tests and integration tests. The changes enable validation of sync functionality, incremental replication, client behavior, and standard tap-tester integration tests.
Key Changes:
- Added unit tests for sync operations, incremental streams, and client functionality
- Added integration tests following tap-tester patterns (discovery, bookmarks, pagination, etc.)
- Uncommented CircleCI configuration to enable test execution in CI/CD pipeline
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unittests/test_sync.py | Unit tests for sync operations including full table and incremental sync scenarios |
| tests/unittests/test_incremental_sync.py | Unit tests for incremental stream behavior, bookmark management, and date handling |
| tests/unittests/test_client.py | Unit tests for Microsoft Graph API client operations including authentication and error handling |
| tests/test_start_date.py | Integration test for start date functionality |
| tests/test_pagination.py | Integration test for pagination handling |
| tests/test_interrupted_sync.py | Integration test for interrupted sync recovery |
| tests/test_discovery.py | Integration test for discovery mode |
| tests/test_bookmark.py | Integration test for bookmark handling |
| tests/test_automatic_fields.py | Integration test for automatic field selection |
| tests/test_all_fields.py | Integration test for all fields replication |
| tests/base.py | Base test class with stream metadata and configuration |
| .circleci/config.yml | Enabled unit and integration test execution in CI pipeline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build is failing. Please fix it |
|
Build is failing due to code checkout issue in circle-ci. |
Description of change
PR Include newly added unit test cases and integration test cases.
SAC-29908
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code