Skip to content

Tdl 25431/add region name in config#64

Open
rdeshmukh15 wants to merge 4 commits intomasterfrom
TDL-25431/add-region-name-in-config
Open

Tdl 25431/add region name in config#64
rdeshmukh15 wants to merge 4 commits intomasterfrom
TDL-25431/add-region-name-in-config

Conversation

@rdeshmukh15
Copy link
Member

@rdeshmukh15 rdeshmukh15 commented Mar 21, 2024

Description of change

  • When listing down the objects in the s3 bucket which is located in other than the default region (i.e. us-east-1), tap throws IllegalLocationConstraintException. And, to resolve this, we are passing region_name as a user configurable property while creating s3_client (TDL-25431)
  • Respective updates in README.md
  • Release related changes in setup.py and CHANGELOG.md

Manual QA steps

  • Executed the tap in discover and sync mode

Risks

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant