Skip to content

Comments

Add query params#104

Open
nschairer wants to merge 6 commits intosinger-io:masterfrom
nschairer:add-query-params
Open

Add query params#104
nschairer wants to merge 6 commits intosinger-io:masterfrom
nschairer:add-query-params

Conversation

@nschairer
Copy link

@nschairer nschairer commented Dec 2, 2021

Description of change

Added support to include arbitrary query parameters for any resource's web requests. Query parameters must be included in the json catalog at the level of "selected" under the key "query" as key value pairs in a json object.

Example:

"metadata": [
                {
                    "breadcrumb": [],
                    "metadata": {
                        "table-key-properties": [
                            "id"
                        ],
                        "forced-replication-method": "INCREMENTAL",
                        "valid-replication-keys": [
                            "created"
                        ],
                        "selected": true,
                        "query": {
                            "status": "all"
                        }
                    }
                },
               ...
]

Manual QA steps

Validated that the tap still runs in our dev environment with and without query parameters.

Risks

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant