Skip to content

Comments

Support Refunds and fix Dispute schema for evidence column#168

Open
ilkkapeltola wants to merge 4 commits intosinger-io:masterfrom
ilkkapeltola:refunds
Open

Support Refunds and fix Dispute schema for evidence column#168
ilkkapeltola wants to merge 4 commits intosinger-io:masterfrom
ilkkapeltola:refunds

Conversation

@ilkkapeltola
Copy link

Description of change

This PR does two things:

  • Adds working support for Refunds, which for some reason has so far not been included in the tap
  • Fixes the schema for disputes.evidence. In the current form, the elt fails with the snowflake target (pipelinewise variant) due to the wrong schema

Manual QA steps

  • run the ELT

Risks

  • Others using the tap might have done other custom fixes for the dispute column. It doesn't fail on all rows, just some.

Rollback steps

  • revert this branch

Copy link

@syahdeini syahdeini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants