Skip to content

Comments

SAC-30139 - Add parent id to records#48

Open
MuralidharT03 wants to merge 4 commits intomasterfrom
SAC-30139-fix-missing-data
Open

SAC-30139 - Add parent id to records#48
MuralidharT03 wants to merge 4 commits intomasterfrom
SAC-30139-fix-missing-data

Conversation

@MuralidharT03
Copy link
Contributor

Description of change

Jira ticket: SAC-30139

Manual QA steps

  • - Discovery: Running
  • - Sync: Running

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds parent organization ID tracking to organization action records and fixes a schema validation issue for the bioData field in organization members.

Changes:

  • Added organization_id field to organization action records via modify_object method
  • Updated bioData field in organization members schema to allow null values

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
tap_trello/streams/organization_actions.py Implements modify_object method to inject parent organization ID into action records
tap_trello/schemas/organization_members.json Updates bioData field type to accept null values in addition to objects

Copy link

@RushiT0122 RushiT0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are inconsistencies in the parent definitions, like in some places parents are defined as classes and in some places as strings. Please fix those as well.

@MuralidharT03
Copy link
Contributor Author

I see there are inconsistencies in the parent definitions, like in some places parents are defined as classes and in some places as strings. Please fix those as well.

Requested changes are addressed in the latest commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants