Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds parent organization ID tracking to organization action records and fixes a schema validation issue for the bioData field in organization members.
Changes:
- Added
organization_idfield to organization action records viamodify_objectmethod - Updated
bioDatafield in organization members schema to allow null values
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tap_trello/streams/organization_actions.py | Implements modify_object method to inject parent organization ID into action records |
| tap_trello/schemas/organization_members.json | Updates bioData field type to accept null values in addition to objects |
RushiT0122
requested changes
Jan 27, 2026
RushiT0122
left a comment
There was a problem hiding this comment.
I see there are inconsistencies in the parent definitions, like in some places parents are defined as classes and in some places as strings. Please fix those as well.
Contributor
Author
Requested changes are addressed in the latest commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Jira ticket: SAC-30139
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code